-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make job name check optional in SageMakerTrainingOperator #16327
Make job name check optional in SageMakerTrainingOperator #16327
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
f458b3f
to
27703db
Compare
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
@kaxil thanks for reviewing. Is there anything else I need to do to get this merged? |
Awesome work, congrats on your first merged pull request! |
Nope, all good @olivermeyer 👏 |
thanks for this @olivermeyer , is there any plans doing that for processingJob /transformJob as well ? |
closes: #16299
In this PR I make it possible to avoid listing existing training jobs by adding a
check_if_job_exists
parameter to the SageMakerTrainingOperator.